automatic upgrades: use default version channel everywhere#35342
Merged
automatic upgrades: use default version channel everywhere#35342
Conversation
hugoShaka
force-pushed
the
hugo/add-proxy-version-server
branch
4 times, most recently
from
cc8d429 to
eb76306
Compare
hugoShaka
force-pushed
the
hugo/use-default-update-channel
branch
from
c608252 to
f367546
Compare
hugoShaka
added
the
no-changelog
hugoShaka
requested review from
bernardjkim,
fspmarshall,
marcoandredinis and
r0mant
Contributor
|
If we'd like to avoid too much cloud specific login in the teleport code base, we can configure the cloud specific channels in the teleportcontroller ex: https://github.com/gravitational/cloud/pull/6904 |
Contributor
Author
I added the defaults because cloud-specific code was already relying on this or using hardcoded URLs. This default is required to not break existing integrations. |
hugoShaka
force-pushed
the
hugo/use-default-update-channel
branch
2 times, most recently
from
f589c48 to
bca6cb9
Compare
bernardjkim
reviewed
Dec 13, 2023
Comment on lines
68
to
70
Contributor
There was a problem hiding this comment.
This code is for v15
So, I guess we want to remove this and add it back for the backport PRs
marcoandredinis
approved these changes
Dec 15, 2023
bernardjkim
approved these changes
Dec 15, 2023
r0mant
approved these changes
Dec 15, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Code lgtm but let's please test all affected Discover flows to make sure nothing regresses.
Also, does this cover auto-discovery install scripts (e.g. for EC2) as well?
public-teleport-github-review-bot
Bot
removed request for
espadolini,
fspmarshall and
rudream
This commit: - initializes default upgrade channels based on the server features - makes all integrations use the upgrade channels instead of hitting hardcoded s3 bucket - makes the version channel return its own version if the target version is too high - makes the NoVersion handler properly: returned as an error. This way soneone relying on the version getter doesn't have to check - moves the version kube-agent-updater lib in main teleport libs - add tests for noVersion channels
Co-authored-by: Bernard Kim <bernard@goteleport.com>
hugoShaka
force-pushed
the
hugo/use-default-update-channel
branch
from
bc1c8b9 to
708b1b9
Compare
Merged
bernardjkim
added a commit
that referenced
this pull request
Jan 3, 2024
* Use default upgrade channel This commit: - initializes default upgrade channels based on the server features - makes all integrations use the upgrade channels instead of hitting hardcoded s3 bucket - makes the version channel return its own version if the target version is too high - makes the NoVersion handler properly: returned as an error. This way soneone relying on the version getter doesn't have to check - moves the version kube-agent-updater lib in main teleport libs - add tests for noVersion channels * Update lib/web/join_tokens.go Co-authored-by: Bernard Kim <bernard@goteleport.com> * address marco's feedback * address marco's feedback pt.2 --------- Co-authored-by: Bernard Kim <bernard@goteleport.com>
bernardjkim
added a commit
that referenced
this pull request
Jan 5, 2024
* Use default upgrade channel This commit: - initializes default upgrade channels based on the server features - makes all integrations use the upgrade channels instead of hitting hardcoded s3 bucket - makes the version channel return its own version if the target version is too high - makes the NoVersion handler properly: returned as an error. This way soneone relying on the version getter doesn't have to check - moves the version kube-agent-updater lib in main teleport libs - add tests for noVersion channels * Update lib/web/join_tokens.go Co-authored-by: Bernard Kim <bernard@goteleport.com> * address marco's feedback * address marco's feedback pt.2 --------- Co-authored-by: Bernard Kim <bernard@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Add a version server in the proxy + use it in agent chart (#35150) This PR adds an embedded [version server](https://goteleport.com/docs/architecture/agent-update-management/#version-server-and-source-of-truth) in the proxy to address: gravitational/cloud#6773 The version server can be configured through `teleport.yaml`: ```yaml proxy_service: enabled: "yes" automatic_upgrades_channels: stable/cloud: forward_url: https://updates.releases.teleport.dev/v1/stable/cloud preview/cloud: static_version: v12.5.4 ``` The forwarded call results are cached for a minute. * automatic upgrades: use default version channel everywhere (#35342) * Use default upgrade channel This commit: - initializes default upgrade channels based on the server features - makes all integrations use the upgrade channels instead of hitting hardcoded s3 bucket - makes the version channel return its own version if the target version is too high - makes the NoVersion handler properly: returned as an error. This way soneone relying on the version getter doesn't have to check - moves the version kube-agent-updater lib in main teleport libs - add tests for noVersion channels * Update lib/web/join_tokens.go Co-authored-by: Bernard Kim <bernard@goteleport.com> * address marco's feedback * address marco's feedback pt.2 --------- Co-authored-by: Bernard Kim <bernard@goteleport.com> * Fix teleport.e integrations builds (#35996) * Move automaticupgrades packages in `lib/automaticupgrades` * Fix `kube-agent-udpater` Dockerfile * Write handler config (#35998) * go mod tidy * Bump controller-runtime v0.16.3 * Use channel --------- Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Part of https://github.com/gravitational/cloud/issues/6773